Add Canvas Capture Strategy #4777
Open
+1,450
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-java into markushi/canvas-approach
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| bdbe1f4 | 380.66 ms | 464.44 ms | 83.78 ms |
| 9fbb112 | 359.71 ms | 421.85 ms | 62.14 ms |
| ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
| 3998a95 | 415.94 ms | 478.54 ms | 62.60 ms |
| 14ff5ee | 419.75 ms | 495.73 ms | 75.98 ms |
| ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
| b750b96 | 408.98 ms | 480.32 ms | 71.34 ms |
| c8125f3 | 397.65 ms | 485.14 ms | 87.49 ms |
| b750b96 | 421.25 ms | 444.09 ms | 22.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| bdbe1f4 | 1.58 MiB | 2.11 MiB | 538.88 KiB |
| 9fbb112 | 1.58 MiB | 2.11 MiB | 539.18 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 3998a95 | 1.58 MiB | 2.10 MiB | 532.96 KiB |
| 14ff5ee | 1.58 MiB | 2.10 MiB | 535.08 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.19 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
Previous results on branch: markushi/canvas-approach
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 04bebea | 403.28 ms | 417.84 ms | 14.56 ms |
| 1b16487 | 375.34 ms | 440.81 ms | 65.47 ms |
| 8b7fc28 | 390.50 ms | 444.36 ms | 53.86 ms |
| 1b42121 | 377.29 ms | 423.63 ms | 46.34 ms |
| 0a0b1e3 | 353.33 ms | 370.31 ms | 16.98 ms |
| 8b9eb06 | 389.33 ms | 448.42 ms | 59.09 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 04bebea | 1.58 MiB | 2.12 MiB | 547.06 KiB |
| 1b16487 | 1.58 MiB | 2.12 MiB | 547.06 KiB |
| 8b7fc28 | 1.58 MiB | 2.11 MiB | 543.01 KiB |
| 1b42121 | 1.58 MiB | 2.12 MiB | 547.01 KiB |
| 0a0b1e3 | 1.58 MiB | 2.11 MiB | 542.83 KiB |
| 8b9eb06 | 1.58 MiB | 2.12 MiB | 547.07 KiB |
romtsn
reviewed
Oct 6, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/WindowRecorder.kt
Show resolved
Hide resolved
romtsn
reviewed
Oct 6, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/CanvasStrategy.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Oct 6, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/CanvasStrategy.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Oct 6, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/CanvasStrategy.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Oct 6, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/CanvasStrategy.kt
Show resolved
Hide resolved
romtsn
reviewed
Oct 6, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/CanvasStrategy.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Oct 6, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/CanvasStrategy.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Oct 7, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/CanvasStrategy.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Oct 7, 2025
sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/PixelCopyStrategy.kt
Outdated
Show resolved
Hide resolved
markushi
requested review from
adinauer,
lcian and
stefanosiano
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/CanvasStrategy.kt
Outdated
Show resolved
Hide resolved
|
| val canvas = surface.lockHardwareCanvas() | ||
| canvas.drawColor(Color.BLACK, PorterDuff.Mode.CLEAR) | ||
| holder.picture.draw(canvas) | ||
| surface.unlockCanvasAndPost(canvas) |
There was a problem hiding this comment.
Bug: Canvas Locking Issue in Picture Render Task
The pictureRenderTask in CanvasStrategy has a potential resource leak. If an exception occurs after surface.lockHardwareCanvas(), the canvas may remain locked because surface.unlockCanvasAndPost() is not guaranteed to execute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds an experimental option to enable an alternate way to capture screenshots, using a fake Canvas which draws rectangles instead of text, producing a safer way to mask all sensitive content.
💡 Motivation and Context
No masking issues.
💚 How did you test it?
Manually
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps